Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 26 Jan 2018 19:27:06 +0200 | Subject | Re: [PATCH 1/2] tools lib symbol: Use strtoul instead of hex2u64 in kallsyms__parse |
| |
On Fri, Jan 26, 2018 at 7:22 PM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Fri, Jan 19, 2018 at 6:11 PM, Jiri Olsa <jolsa@kernel.org> wrote: >> Current kallsyms__parse uses hex2u64, which gives >> no indication of error. Using strtoul to checkup >> on failed attempt to parse the number and stop the >> rest of the kallsyms__parse processing early. > >> + start = strtoul(line, &endptr, 16); >> + if (line == endptr) >> + continue; >> + >> + len = endptr - line + 1; >> >> - len++; >> if (len + 2 >= line_len) >> continue; > > https://patchwork.kernel.org/patch/4087681/
Even second attempt including recent ping left without consideration.
http://lkml.iu.edu/hypermail/linux/kernel/1407.0/02791.html
-- With Best Regards, Andy Shevchenko
| |