lkml.org 
[lkml]   [2018]   [Jan]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH 6/8] kprobes/arm64: Fix %p uses in error messages
On Thu, 25 Jan 2018 16:42:31 +0000
Will Deacon <will.deacon@arm.com> wrote:

> On Thu, Jan 25, 2018 at 02:29:32PM +0900, Masami Hiramatsu wrote:
> > Fix %p uses in error messages by removing it because
> > those are redundant or meaningless.
> >
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > arch/arm64/kernel/probes/kprobes.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Will Deacon <will.deacon@arm.com>
>
> I guess Catalin can just pick this one up via arm64.

OK, thanks!

>
> Will
>
> > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c
> > index d849d9804011..34f78d07a068 100644
> > --- a/arch/arm64/kernel/probes/kprobes.c
> > +++ b/arch/arm64/kernel/probes/kprobes.c
> > @@ -275,7 +275,7 @@ static int __kprobes reenter_kprobe(struct kprobe *p,
> > break;
> > case KPROBE_HIT_SS:
> > case KPROBE_REENTER:
> > - pr_warn("Unrecoverable kprobe detected at %p.\n", p->addr);
> > + pr_warn("Unrecoverable kprobe detected.\n");
> > dump_kprobe(p);
> > BUG();
> > break;
> > @@ -521,7 +521,7 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs)
> > (struct pt_regs *)kcb->jprobe_saved_regs.sp;
> > pr_err("current sp %lx does not match saved sp %lx\n",
> > orig_sp, stack_addr);
> > - pr_err("Saved registers for jprobe %p\n", jp);
> > + pr_err("Saved registers for jprobe\n");
> > __show_regs(saved_regs);
> > pr_err("Current registers\n");
> > __show_regs(regs);
> >


--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2018-01-26 06:41    [W:0.037 / U:3.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site