lkml.org 
[lkml]   [2018]   [Jan]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] x86/mm/encrypt: Move sme_populate_pgd*() into separate translation unit
On Wed, Jan 24, 2018 at 02:59:58PM +0000, Tom Lendacky wrote:
> > static void __init sme_clear_pgd(struct sme_populate_pgd_data *ppd)
>
> If you're going to move some of the functions, did you look at moving the
> sme_enable(), sme_encrypt_kernel(), etc., too? I believe everything below
> the sme_populate_pgd_data structure is used during early identity-mapped
> boot time. If you move everything, then mm_internal.h doesn't need to be
> updated and all of the identity-mapped early boot code ends up in one
> file.
>
> You'd have to move the command line declarations and make sev_enabled
> not a static, but it should be doable.

I moved minimum of the code to get the trick work, but I'll look into
moving move there.

--
Kirill A. Shutemov

\
 
 \ /
  Last update: 2018-01-24 16:52    [W:0.047 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site