Messages in this thread | | | Subject | Re: [PATCH v18 08/10] drm/omapdrm: Use backlight_enable/disable helpers | From | Noralf Trønnes <> | Date | Tue, 23 Jan 2018 15:20:11 +0100 |
| |
Den 22.01.2018 15.54, skrev Meghana Madhyastha: > Use backlight_enable/disable helpers instead of changing > the property and calling backlight_update_status for cleaner > and simpler code and also to avoid repetitions. > > Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com> > ---
Reviewed-by: Noralf Trønnes<noralf@tronnes.org>
> drivers/gpu/drm/omapdrm/displays/panel-dpi.c | 11 ++--------- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c > index e065f7e10..ac9596251 100644 > --- a/drivers/gpu/drm/omapdrm/displays/panel-dpi.c > +++ b/drivers/gpu/drm/omapdrm/displays/panel-dpi.c > @@ -87,11 +87,7 @@ static int panel_dpi_enable(struct omap_dss_device *dssdev) > } > > gpiod_set_value_cansleep(ddata->enable_gpio, 1); > - > - if (ddata->backlight) { > - ddata->backlight->props.power = FB_BLANK_UNBLANK; > - backlight_update_status(ddata->backlight); > - } > + backlight_enable(ddata->backlight); > > dssdev->state = OMAP_DSS_DISPLAY_ACTIVE; > > @@ -106,10 +102,7 @@ static void panel_dpi_disable(struct omap_dss_device *dssdev) > if (!omapdss_device_is_enabled(dssdev)) > return; > > - if (ddata->backlight) { > - ddata->backlight->props.power = FB_BLANK_POWERDOWN; > - backlight_update_status(ddata->backlight); > - } > + backlight_disable(ddata->backlight); > > gpiod_set_value_cansleep(ddata->enable_gpio, 0); > regulator_disable(ddata->vcc_supply);
| |