Messages in this thread | | | Date | Mon, 22 Jan 2018 15:43:18 -0500 (EST) | Subject | Re: [PATCH net-next v2] net: core: Expose number of link up/down transitions | From | David Miller <> |
| |
From: Florian Fainelli <f.fainelli@gmail.com> Date: Thu, 18 Jan 2018 09:59:13 -0800
> From: David Decotigny <decot@googlers.com> > > Expose the number of times the link has been going UP or DOWN, and > update the "carrier_changes" counter to be the sum of these two events. > While at it, also update the sysfs-class-net documentation to cover: > carrier_changes (3.15), carrier_up_count (4.16) and carrier_down_count > (4.16) > > Signed-off-by: David Decotigny <decot@googlers.com> > [Florian: > * rebase > * add documentation > * merge carrier_changes with up/down counters] > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > Changes in v2: > - fixed sysfs attributes to use <iface> > - renamed count_link_{up,down} to carrier_{up,down}_count to match > existing carrier_changes semantics
Like David Ahern I am strongly against the proliferation of sysfs files attached to network devices and the per-netdevice costs associated with that.
However, dealing with that is a longer term issue that nobody has a clear plan for. Therefore I cannot reject this change on that basis alone.
The information is useful, so applied, thanks.
| |