Messages in this thread | | | Subject | Re: [PATCH] Input: edt-ft5x06: Delete an error message for a failed memory allocation in edt_ft5x06_ts_probe() | From | Martin Kepplinger <> | Date | Mon, 22 Jan 2018 08:00:47 +0100 |
| |
On 2018-01-21 20:19, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 21 Jan 2018 20:10:03 +0100 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Martin Kepplinger <martink@posteo.de>
> --- > drivers/input/touchscreen/edt-ft5x06.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c > index c53a3d7239e7..9d2799c90150 100644 > --- a/drivers/input/touchscreen/edt-ft5x06.c > +++ b/drivers/input/touchscreen/edt-ft5x06.c > @@ -978,10 +978,8 @@ static int edt_ft5x06_ts_probe(struct i2c_client *client, > dev_dbg(&client->dev, "probing for EDT FT5x06 I2C\n"); > > tsdata = devm_kzalloc(&client->dev, sizeof(*tsdata), GFP_KERNEL); > - if (!tsdata) { > - dev_err(&client->dev, "failed to allocate driver data.\n"); > + if (!tsdata) > return -ENOMEM; > - } > > chip_data = of_device_get_match_data(&client->dev); > if (!chip_data) >
| |