Messages in this thread | | | Date | Tue, 2 Jan 2018 08:56:27 -0500 (EST) | From | Bob Peterson <> | Subject | Re: [Cluster-devel] [PATCH 00/12] drop unneeded newline |
| |
----- Original Message ----- | ----- Original Message ----- | | Drop newline at the end of a message string when the printing function adds | | a newline. | | Hi Julia, | | NACK. | | As much as it's a pain when searching the source code for output strings, | this patch set goes against the accepted Linux coding style document. See: | | https://www.kernel.org/doc/html/v4.10/process/coding-style.html#breaking-long-lines-and-strings | | Regards, | | Bob Peterson | | Hm. I guess I stand corrected. The document reads:
"However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them."
Still, the GFS2 and DLM code has a plethora of broken-up printk messages, and I don't like the thought of re-combining them all.
Regards,
Bob Peterson
| |