Messages in this thread | | | Date | Fri, 19 Jan 2018 12:47:19 +0800 | From | Dave Young <> | Subject | Re: [PATCH] print kdump kernel loaded status in stack dump |
| |
On 01/18/18 at 01:57pm, Steven Rostedt wrote: > On Thu, 18 Jan 2018 10:02:17 -0800 > Andi Kleen <ak@linux.intel.com> wrote: > > > Dave Young <dyoung@redhat.com> writes: > > > printk("%sHardware name: %s\n", > > > log_lvl, dump_stack_arch_desc_str); > > > + if (kexec_crash_loaded()) > > > + printk("%skdump kernel loaded\n", log_lvl); > > > > Oops/warnings are getting longer and longer, often scrolling away > > from the screen, and if the kernel crashes backscroll does not work > > anymore, so precious information is lost. > > > > Can you merge it with some other line? > > > > Just a [KDUMP] or so somewhere should be good enough. > > Or perhaps we should add it as a TAINT. Not all taints are bad.
Hmm, I also thought about this before but It sounds like not match the "tainted" meaning with the assumption that it is bad :(
Maybe it would be better to do like Andi said, but print a better word than "KDUMP", eg. "Kdumpable" sounds better. If this is fine I can repost the patch.
> > -- Steve
Thanks Dave
| |