lkml.org 
[lkml]   [2018]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH-next] init/main.c: make local symbol static
From
Date
On 1/18/2018 4:09 PM, Randy Dunlap wrote:
> On 01/18/2018 02:06 PM, Christopher Díaz Riveros wrote:
>> Fixes the following sparse warning:
>>
>> init/main.c:167:12: warning:
>> symbol 'envp_init' was not declared. Should it be static?
>>
>> Signed-off-by: Christopher Díaz Riveros <chrisadr@gentoo.org>
>
> Does the kernel build OK after this change?
>
> What about the other user(s) of envp_init?

It looks like it's referenced in init/do_mounts_initrd.c. Rather
than making it static, it should be declared in .h file.

Thanks,
Tom

>
>
>> ---
>> init/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/init/main.c b/init/main.c
>> index a8100b954839..ae86addb306c 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -164,7 +164,7 @@ static int __init set_reset_devices(char *str)
>> __setup("reset_devices", set_reset_devices);
>>
>> static const char *argv_init[MAX_INIT_ARGS+2] = { "init", NULL, };
>> -const char *envp_init[MAX_INIT_ENVS+2] = { "HOME=/", "TERM=linux", NULL, };
>> +static const char *envp_init[MAX_INIT_ENVS+2] = { "HOME=/", "TERM=linux", NULL, };
>> static const char *panic_later, *panic_param;
>>
>> extern const struct obs_kernel_param __setup_start[], __setup_end[];
>>
>
>

\
 
 \ /
  Last update: 2018-01-18 23:31    [W:0.052 / U:1.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site