Messages in this thread | | | Date | Thu, 18 Jan 2018 10:52:46 +0530 | From | poza@codeauro ... | Subject | Re: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC |
| |
On 2018-01-17 22:15, Sinan Kaya wrote: > On 1/17/2018 5:37 AM, Oza Pawandeep wrote: >> + driver = pci_find_dpc_service(udev); >> +#endif >> #if IS_ENABLED(CONFIG_PCIEAER) >> - /* Use the aer driver of the component firstly */ >> - driver = pci_find_aer_service(udev); > > I think we need a pci_find_service function that unifies these two.
Right now, find_xxx_service are in their respective file and exporting it. which makes sense no less than having generic function.
If I have to change pci_find_service(...., int service_name) then it has to be somewhere in generic file. probably portdrv_core.c
either way I am fine but just thinking out if its really required.
Regards, Oza.
| |