Messages in this thread | | | Subject | Re: [PATCH] crypto: ux500/hash: Add empty export and import | From | Kamil Konieczny <> | Date | Thu, 18 Jan 2018 13:52:50 +0100 |
| |
On 18.01.2018 11:06, Linus Walleij wrote: > On Tue, Jan 16, 2018 at 5:32 PM, Kamil Konieczny > <k.konieczny@partner.samsung.com> wrote: > >> Crypto framework will require async hash export/import, so add empty >> functions to prevent OOPS. >> >> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > But why isn't the framework code just checking the vtable for NULL? > > if (foo->fp) > foo->fp(bar);
This will be inefficient, it should be checked once at ahash alg register, or with the old method by using wrapper
-- Best regards, Kamil Konieczny Samsung R&D Institute Poland
| |