lkml.org 
[lkml]   [2018]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3/4] PCI/DPC: Unify and plumb error handling into DPC
On 2018-01-18 10:52, poza@codeaurora.org wrote:
> On 2018-01-17 22:15, Sinan Kaya wrote:
>> On 1/17/2018 5:37 AM, Oza Pawandeep wrote:
>>> + driver = pci_find_dpc_service(udev);
>>> +#endif
>>> #if IS_ENABLED(CONFIG_PCIEAER)
>>> - /* Use the aer driver of the component firstly */
>>> - driver = pci_find_aer_service(udev);
>>
>> I think we need a pci_find_service function that unifies these two.
>
> Right now, find_xxx_service are in their respective file and exporting
> it.
> which makes sense no less than having generic function.
>
> If I have to change pci_find_service(...., int service_name) then it
> has to be somewhere in generic file.
> probably portdrv_core.c
>
> either way I am fine but just thinking out if its really required.
>
> Regards,
> Oza.

Should I be doing in next patch-set series ?

Regards,
Oza.

\
 
 \ /
  Last update: 2018-01-18 07:05    [W:0.046 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site