| From | Arnd Bergmann <> | Date | Thu, 18 Jan 2018 11:41:25 +0100 | Subject | Re: [PATCH v6 24/36] nds32: Loadable modules |
| |
On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu <green.hu@gmail.com> wrote: > From: Greentime Hu <greentime@andestech.com> > > This patch adds support for loadable modules.
One detail:
You still seem to have both the ELF_REL and ELF_RELA based functions implemented here, you should drop the unused ELF_REL version:
> diff --git a/arch/nds32/kernel/module.c b/arch/nds32/kernel/module.c > new file mode 100644 > index 0000000..714a6d6 > --- /dev/null > +++ b/arch/nds32/kernel/module.c > @@ -0,0 +1,286 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// Copyright (C) 2005-2017 Andes Technology Corporation > + > +#include <linux/module.h> > +#include <linux/elf.h> > +#include <linux/vmalloc.h> > + > +#include <asm/pgtable.h>
include <linux/moduleloader.h> to catch this.
> +int > +apply_relocate(Elf32_Shdr * sechdrs, const char *strtab, > + unsigned int symindex, unsigned int relsec, > + struct module *module) > +{ > + return 0; > +}
and drop this.
With that change,
Acked-by: Arnd Bergmann <arnd@arndb.de>
|