lkml.org 
[lkml]   [2018]   [Jan]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V5 1/8] perf/x86/intel/uncore: customized event_read for client IMC uncore
    On Mon, 15 Jan 2018, kan.liang@intel.com wrote:

    > From: Kan Liang <Kan.liang@intel.com>
    >
    > There are two free running counters for client IMC uncore. The custom
    > event_init() function hardcode their index to 'UNCORE_PMC_IDX_FIXED' and
    > 'UNCORE_PMC_IDX_FIXED + 1'. To support the 'UNCORE_PMC_IDX_FIXED + 1'
    > case, the generic uncore_perf_event_update is obscurely hacked.
    > The code quality issue will bring problem when new counter index is
    > introduced into generic code. For example, free running counter index.
    >
    > Introduce customized event_read function for client IMC uncore.
    > The customized function is exactly copied from previous generic
    > uncore_pmu_event_read.
    > The 'UNCORE_PMC_IDX_FIXED + 1' case will be isolated for client IMC
    > uncore only.
    >
    > Signed-off-by: Kan Liang <Kan.liang@intel.com>

    Reviewed-by: Thomas Gleixner <tglx@linutronix.de>

    \
     
     \ /
      Last update: 2018-01-18 10:37    [W:4.163 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site