Messages in this thread | | | Date | Tue, 16 Jan 2018 11:48:44 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH v1 0/8] perf: Follow-up patches to improve time slice |
| |
Em Tue, Jan 16, 2018 at 12:55:19PM +0100, Jiri Olsa escreveu: > On Wed, Jan 10, 2018 at 11:00:25PM +0800, Jin Yao wrote: > > It's follow-up patches to improve the perf time slice feature > > (perf report/script --time xxx) > > > > 1. Improve the error message > > perf report: Improve error msg when no first/last sample time found > > perf script: Improve error msg when no first/last sample time found > > > > 2. Fix an issue that illegal percent was accepted previously (e.g. 1abc%) > > perf util: Improve error checking for time percent input > > > > 3. Omit the slice index if possible. For example, > > perf report --stdio --time 10%/1 is equivalent to > > perf report --stdio --time 10% > > > > perf util: Support no index time percent slice > > > > 4. Add indication of time slices in perf report header. > > perf report: Add an indication of what time slices are used > > > > 5. Remove the time slices number limitation in perf report/script > > perf util: Allocate time slices buffer according to number of comma > > perf report: Remove the time slices number limitation > > perf script: Remove the time slices number limitation > > > > Jin Yao (8): > > perf report: Improve error msg when no first/last sample time found > > perf script: Improve error msg when no first/last sample time found > > perf util: Improve error checking for time percent input > > perf util: Support no index time percent slice > > perf report: Add an indication of what time slices are used > > perf util: Allocate time slices buffer according to number of comma > > perf report: Remove the time slices number limitation > > perf script: Remove the time slices number limitation > > from quick look it looks ok > > Reviewed-by: Jiri Olsa <jolsa@redhat.com>
Thanks, applied, now test building with 'make -C tools/perf build-test', containers, etc.
- Arnaldo
| |