lkml.org 
[lkml]   [2018]   [Jan]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 0/8] perf: Follow-up patches to improve time slice
Em Tue, Jan 16, 2018 at 12:55:19PM +0100, Jiri Olsa escreveu:
> On Wed, Jan 10, 2018 at 11:00:25PM +0800, Jin Yao wrote:
> > It's follow-up patches to improve the perf time slice feature
> > (perf report/script --time xxx)
> >
> > 1. Improve the error message
> > perf report: Improve error msg when no first/last sample time found
> > perf script: Improve error msg when no first/last sample time found
> >
> > 2. Fix an issue that illegal percent was accepted previously (e.g. 1abc%)
> > perf util: Improve error checking for time percent input
> >
> > 3. Omit the slice index if possible. For example,
> > perf report --stdio --time 10%/1 is equivalent to
> > perf report --stdio --time 10%
> >
> > perf util: Support no index time percent slice
> >
> > 4. Add indication of time slices in perf report header.
> > perf report: Add an indication of what time slices are used
> >
> > 5. Remove the time slices number limitation in perf report/script
> > perf util: Allocate time slices buffer according to number of comma
> > perf report: Remove the time slices number limitation
> > perf script: Remove the time slices number limitation
> >
> > Jin Yao (8):
> > perf report: Improve error msg when no first/last sample time found
> > perf script: Improve error msg when no first/last sample time found
> > perf util: Improve error checking for time percent input
> > perf util: Support no index time percent slice
> > perf report: Add an indication of what time slices are used
> > perf util: Allocate time slices buffer according to number of comma
> > perf report: Remove the time slices number limitation
> > perf script: Remove the time slices number limitation
>
> from quick look it looks ok
>
> Reviewed-by: Jiri Olsa <jolsa@redhat.com>

Thanks, applied, now test building with 'make -C tools/perf build-test',
containers, etc.

- Arnaldo

\
 
 \ /
  Last update: 2018-01-16 15:49    [W:0.127 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site