Messages in this thread | | | Date | Mon, 15 Jan 2018 15:48:19 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/2] staging: lustre: lnet: convert selftest to use workqueues |
| |
On Thu, Jan 11, 2018 at 03:06:40PM +1100, NeilBrown wrote: > Instead of the cfs workitem library, use workqueues. > > As lnet wants to provide a cpu mask of allowed cpus, it > needs to be a WQ_UNBOUND work queue so that tasks can > run on cpus other than where they were submitted. > > This patch also exported apply_workqueue_attrs() which is > a documented part of the workqueue API, that isn't currently > exported. lustre needs it to allow workqueue thread to be limited > to a subset of CPUs. > > Acked-by: Tejun Heo <tj@kernel.org> (for export of apply_workqueue_attrs) > Signed-off-by: NeilBrown <neilb@suse.com>
I now see the following build warning with this patch applied:
drivers/staging/lustre/lnet/selftest/module.c: In function ‘lnet_selftest_init’: drivers/staging/lustre/lnet/selftest/module.c:98:10: warning: ‘rc’ may be used uninitialized in this function [-Wmaybe-uninitialized] return rc; ^~
Care to send a follow-on patch to fix it up?
thanks,
greg k-h
| |