Messages in this thread | | | Date | Mon, 15 Jan 2018 14:51:02 +0100 | From | Thierry Reding <> | Subject | Re: [Nouveau] [PATCH] fix drm-get-put.cocci warnings |
| |
On Mon, Jan 15, 2018 at 01:47:07PM +0100, Julia Lawall wrote: > From: Fengguang Wu <fengguang.wu@intel.com> > > Use drm_*_get() and drm_*_put() helpers instead of drm_*_reference() and > drm_*_unreference() helpers. > > Generated by: scripts/coccinelle/api/drm-get-put.cocci > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > --- > > tree: https://github.com/thierryreding/linux for-4.16/work > head: 6c86494bb2f670293f6137b0a4b3c53c8886eba4 > commit: 34f022b2d11f91a323d3e7d15893d480646f3fad [149/161] WIP > > nouveau_gem.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-)
Hi Julia,
thanks for the patch. However, the tree that you generated it against is a personal development tree and it happens to have a bunch of commits in it that are very experimental and some of which are very unlikely to go upstream. There's an IOCTL addition patch (touched by hunk 7 in this patch) that is used only for testing purposes. All of the other hunks do pply properly to linux-next, so I think those can be posted. Nouveau is maintained by Ben Skeggs, though, so they should be addressed to him.
I don't personally mind getting these patches, and I don't mind people seeing the personal development tree (it's publicly available, after all) but I think patches against this tree will be confusing to anyone but me because they are likely not going to apply anywhere other than that tree.
Thanks, Thierry [unhandled content-type:application/pgp-signature] | |