Messages in this thread | | | Date | Mon, 15 Jan 2018 06:54:27 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH] tools/lib/traceevent/event-parse: delete pevent_register_function |
| |
On Mon, 15 Jan 2018 11:08:34 +0100 Jiri Olsa <jolsa@redhat.com> wrote:
> On Mon, Jan 15, 2018 at 12:50:14PM +0800, Wang YanQing wrote: > > After commit 4263cece22e3da94f16fbbcf71ce3807946d3ef3 > > ("perf tools: Stop reading the kallsyms data from perf.data"), > > there is no users of pevent_register_function in tree, so we > > could just delete it. > > > > I don't think you can remove this function, > perf is not the only user there
Correct. The tools/lib does not have the same requirements as the kernel code. It's purpose is to be a library for other tools, not just what is in tree. Otherwise, I would be happy to add trace-cmd to the kernel proper, as that is where this code originated from.
Don't delete those functions. They are required elsewhere.
-- Steve
| |