lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] powerpc/pseries: include linux/types.h in asm/hvcall.h
Date
Michal Suchanek <msuchanek@suse.de> writes:

> Commit 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings") uses u64 in asm/hvcall.h without including linux/types.h
>
> This breaks hvcall.h users that do not include the header themselves.
>
> Fixes: 6e032b350cd1 ("powerpc/powernv: Check device-tree for RFI flush
> settings")
>
> Signed-off-by: Michal Suchanek <msuchanek@suse.de>
> ---
> arch/powerpc/include/asm/hvcall.h | 1 +
> 1 file changed, 1 insertion(+)

Thanks. None of my ~250 defconfig test builds hit this, what config are
you using?

cheers

> diff --git a/arch/powerpc/include/asm/hvcall.h b/arch/powerpc/include/asm/hvcall.h
> index f0461618bf7b..eca3f9c68907 100644
> --- a/arch/powerpc/include/asm/hvcall.h
> +++ b/arch/powerpc/include/asm/hvcall.h
> @@ -353,6 +353,7 @@
> #define PROC_TABLE_GTSE 0x01
>
> #ifndef __ASSEMBLY__
> +#include <linux/types.h>
>
> /**
> * plpar_hcall_norets: - Make a pseries hypervisor call with no return arguments
> --
> 2.13.6

\
 
 \ /
  Last update: 2018-01-16 04:17    [W:0.254 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site