Messages in this thread | | | Date | Mon, 15 Jan 2018 20:33:42 +0100 | From | Ladislav Michl <> | Subject | Re: mfd/omap-usb-tll: Allocate driver data at once in usbtll_omap_probe() |
| |
On Mon, Jan 15, 2018 at 08:26:00PM +0100, SF Markus Elfring wrote: > > dev_dbg(dev, > > "USB TLL Rev : 0x%x not recognized, assuming %d channels\n", > > - ver, tll->nch); > > + ver, nch); > > break; > > Does this format string need an other indentation when you touch this statement?
Well, lets that the chance and make it shorter as well:
default: - tll->nch = OMAP_TLL_CHANNEL_COUNT; - dev_dbg(dev, - "USB TLL Rev : 0x%x not recognized, assuming %d channels\n", - ver, tll->nch); + nch = OMAP_TLL_CHANNEL_COUNT; + dev_dbg(dev, "rev 0x%x not recognized, assuming %d channels\n", + ver, nch); break;
Other proposals?
| |