lkml.org 
[lkml]   [2018]   [Jan]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/5] pktgen: Add behavior flag names array - pkt_flag_names
From
Date
On Mon, 2018-01-15 at 13:09 -0500, David Miller wrote:
> From: Dmitry Safonov <dima@arista.com>
> Date: Tue, 9 Jan 2018 13:55:33 +0000
>
> > +#define pf(flag) __stringify(flag),
> > +char *pkt_flag_names[] = {
> > + PKT_FLAGS
> > +};
> > +#undef pf
>
> This should be static, also you don't use this table in this patch.
> You
> should add the table in the patch that actually uses the table.

Sure, will do.

--
Thanks,
Dmitry

\
 
 \ /
  Last update: 2018-01-15 19:16    [W:0.056 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site