Messages in this thread | | | Date | Sun, 14 Jan 2018 09:53:45 -0600 | From | Josh Poimboeuf <> | Subject | Re: [PATCH v8 03/12] x86/retpoline: Add initial retpoline support |
| |
On Sun, Jan 14, 2018 at 04:02:19PM +0100, Borislav Petkov wrote: > On Thu, Jan 11, 2018 at 09:46:25PM +0000, David Woodhouse wrote: > > +/* > > + * This should be used immediately before a retpoline alternative. It tells > > + * objtool where the retpolines are so that it can make sense of the control > > + * flow by just reading the original instruction(s) and ignoring the > > + * alternatives. > > + */ > > +.macro ANNOTATE_NOSPEC_ALTERNATIVE > > + .Lannotate_\@: > > + .pushsection .discard.nospec > > + .long .Lannotate_\@ - . > > + .popsection > > +.endm > > Hey Josh, what happened to parsing only the retpoline-related > .altinstructions sections with the X86_FEATURE bits? Or is this > annotation used for something more additionally?
Yeah, that idea came after this patch was already written. I haven't implemented it yet.
-- Josh
| |