Messages in this thread | | | Subject | Re: [PATCH] Staging: netlogic: platform_net: Fixed '(' at the EOL | From | Joe Perches <> | Date | Sun, 14 Jan 2018 12:22:06 -0800 |
| |
On Sun, 2018-01-14 at 20:10 +0000, Al Viro wrote: > On Sun, Jan 14, 2018 at 11:47:11PM +0530, Naveen Panwar wrote: > > Removed '(' from the end of line, coding style issue. > > The one and only reason for warnings is that they point to > places more likely to be dodgy. There is no inherent value > in having e.g. checkpatch.pl STFU, all wanking about uniformity > of style nonwithstanding.
[ long and complete response removed, available at https://patchwork.kernel.org/patch/10162725/ ]
It was very generous of you to spend so much time on that informative and thorough reply Al.
My own response was _much_ more terse.
What I wonder is if that sort of guided response can be setup as documentation for kernel-newbies / janitors so that future new submitters can have better ideas as to what code can and should be improved instead of getting simple and sometimes ill-advised whitespace changes.
cheers, Joe
| |