Messages in this thread | | | Date | Fri, 12 Jan 2018 18:08:39 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH] pci/setup-bus: Delete an error message for a failed memory allocation in add_to_list() |
| |
On Fri, Dec 29, 2017 at 12:47:11PM +0100, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 29 Dec 2017 12:15:16 +0100 > > Omit an extra message for a memory allocation failure in this function.
If this is an "extra" message, I assume there's some other message? Can you mention where that is in the changelog?
Also, please squash all the drivers/pci patches into one.
> This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/pci/setup-bus.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c > index b1ad466199ad..d131d29c4fdb 100644 > --- a/drivers/pci/setup-bus.c > +++ b/drivers/pci/setup-bus.c > @@ -67,10 +67,8 @@ static int add_to_list(struct list_head *head, > struct pci_dev_resource *tmp; > > tmp = kzalloc(sizeof(*tmp), GFP_KERNEL); > - if (!tmp) { > - pr_warn("add_to_list: kmalloc() failed!\n"); > + if (!tmp) > return -ENOMEM; > - } > > tmp->res = res; > tmp->dev = dev; > -- > 2.15.1 >
| |