Messages in this thread | | | Subject | Re: [PATCH] target: don't call an unmap callback if a range length is zero | From | "Nicholas A. Bellinger" <> | Date | Fri, 12 Jan 2018 14:38:22 -0800 |
| |
Hi Andrei,
Apologies for the delayed follow up.
On Wed, 2017-12-13 at 13:55 -0800, Andrei Vagin wrote: > If a length of a range is zero, it means there is nothing to unmap > and we can skip this range. > > Here is one more reason, why we have to skip such ranges. An unmap > callback calls file_operations->fallocate(), but the man page for the > fallocate syscall says that fallocate(fd, mode, offset, let) returns > EINVAL, if len is zero. It means that file_operations->fallocate() isn't > obligated to handle zero ranges too. > > Signed-off-by: Andrei Vagin <avagin@openvz.org> > --- > drivers/target/target_core_sbc.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) >
Applied.
Thank you.
| |