lkml.org 
[lkml]   [2018]   [Jan]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 4/6] kconfig: remove unneeded input_mode test in conf()
On Wed, Jan 10, 2018 at 7:56 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> conf() is never called for listnewconfig / olddefconfig.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> scripts/kconfig/conf.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> index 8364811..693cd5f 100644
> --- a/scripts/kconfig/conf.c
> +++ b/scripts/kconfig/conf.c
> @@ -368,9 +368,7 @@ static void conf(struct menu *menu)
>
> switch (prop->type) {
> case P_MENU:
> - if ((input_mode == silentoldconfig ||
> - input_mode == listnewconfig ||
> - input_mode == olddefconfig) &&
> + if (input_mode == silentoldconfig &&
> rootEntry != menu) {
> check_conf(menu);
> return;
> --
> 2.7.4
>

LGTM

Acked-by: Ulf Magnusson <ulfalizer@gmail.com>

Cheers,
Ulf

\
 
 \ /
  Last update: 2018-01-14 23:25    [W:0.941 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site