Messages in this thread | | | Subject | Re: [PATCH v8.1 12/12] x86/retpoline: Fill return stack buffer on vmexit | Date | Fri, 12 Jan 2018 11:21:54 +0000 | From | "Woodhouse, David" <> |
| |
> On Fri, 2018-01-12 at 12:15 +0100, Thomas Gleixner wrote: > Fair enough. I surely like the below way more than the sloppy hackery from > Andi which completely removed any form of documentation.
Be nice. Andi has been extremely helpful in testing and finding corner cases here, and generally keeping me honest — thanks, Andi.
And I'd have done it *precisely* the same way if you hadn't been whining on IRC about documenting it. There's a ten-line comment right above it, saying what it's doing and why. The addition of a couple of tiny /* speculation trap */ comments inline is really not that much of a benefit. I just did it to shut you up :) [unhandled content-type:application/x-pkcs7-signature] | |