lkml.org 
[lkml]   [2018]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v6 5/5] iommu/vt-d: Add debugfs support for Interrupt remapping
From
Date
On Tue, 2018-01-09 at 19:48 -0800, Sohil Mehta wrote:
> Debugfs extension for Intel IOMMU to dump Interrupt remapping table
> entries for Interrupt remapping and Interrupt posting.
>
> The file /sys/kernel/debug/intel_iommu/ir_translation_struct provides
> detailed information, such as Index, Source Id, Destination Id, Vector
> and the raw values for entries with the present bit set, in the format
> shown.
>
> Remapped Interrupt supported on IOMMU: dmar5
> IR table address:ffff93e09d54c310
> -----------------------------------------------------------
> Index SID Dest_ID Vct Raw_value_high Raw_value_low
> 1 3a00 00000600 2c 0000000000043a00 00000600002c0009
> 111 4301 00000900 a2 0000000000044301 0000090000a20009
>
> Posted Interrupt supported on IOMMU: dmar5
> IR table address:ffff93e09d54c310
> --------------------------------------------------------------------
> Index SID PDA_high PDA_low Vct Raw_value_high Raw_value_low
> 4 4300 00000010 40c7c880 41 0000001000044300 40c7c88000418001
> 5 4300 00000010 40c7c880 51 0000001000044300 40c7c88000518001
>
>

> + seq_printf(m, "Remapped Interrupt supported on IOMMU:
> %s\n"
> + " IR table address:%p\n", iommu->name,
> + iommu->ir_table);

A nit: If you indent second part of string literal to follow the
indentation of first one, it would be slightly better for my opinion.

> + seq_printf(m, "Posted Interrupt supported on IOMMU:
> %s\n"
> + " IR table address:%p\n", iommu->name,
> + iommu->ir_table);

Ditto.

--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

\
 
 \ /
  Last update: 2018-01-14 23:21    [W:1.911 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site