lkml.org 
[lkml]   [2018]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [RFC 1/2] softirq: Defer net rx/tx processing to ksoftirqd context
On Wed, Jan 10, 2018 at 7:22 PM, Frederic Weisbecker
<frederic@kernel.org> wrote:
>
> Makes sense, but I think you need to keep the TASK_RUNNING check.

Yes, good point.

> So perhaps it should be:
>
> - return tsk && (tsk->state == TASK_RUNNING);
> + return (tsk == current) && (tsk->state == TASK_RUNNING);

Looks good to me - definitely worth trying.

Maybe that weakens the thing so much that it doesn't actually help the
UDP packet storm case?

And maybe it's not sufficient for the dvb issue.

But I think it's worth at least testing. Maybe it makes neither side
entirely happy, but maybe it might be a good halfway point?

Linus

\
 
 \ /
  Last update: 2018-01-14 23:22    [W:0.105 / U:0.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site