lkml.org 
[lkml]   [2017]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 042/233] usb: r8a66597-hcd: select a different endpoint on timeout
    3.16.48-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Chris Brandt <chris.brandt@renesas.com>

    commit 1f873d857b6c2fefb4dada952674aa01bcfb92bd upstream.

    If multiple endpoints on a single device have pending IN URBs and one
    endpoint times out due to NAKs (perfectly legal), select a different
    endpoint URB to try.
    The existing code only checked to see another device address has pending
    URBs and ignores other IN endpoints on the current device address. This
    leads to endpoints never getting serviced if one endpoint is using NAK as
    a flow control method.

    Fixes: 5d3043586db4 ("usb: r8a66597-hcd: host controller driver for R8A6659")
    Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/usb/host/r8a66597-hcd.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/usb/host/r8a66597-hcd.c
    +++ b/drivers/usb/host/r8a66597-hcd.c
    @@ -1785,6 +1785,7 @@ static void r8a66597_td_timer(unsigned l
    pipe = td->pipe;
    pipe_stop(r8a66597, pipe);

    + /* Select a different address or endpoint */
    new_td = td;
    do {
    list_move_tail(&new_td->queue,
    @@ -1794,7 +1795,8 @@ static void r8a66597_td_timer(unsigned l
    new_td = td;
    break;
    }
    - } while (td != new_td && td->address == new_td->address);
    + } while (td != new_td && td->address == new_td->address &&
    + td->pipe->info.epnum == new_td->pipe->info.epnum);

    start_transfer(r8a66597, new_td);

    \
     
     \ /
      Last update: 2017-09-10 01:33    [W:4.070 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site