lkml.org 
[lkml]   [2017]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 061/233] serial: ifx6x60: Remove dangerous spi_driver casts
    3.16.48-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Geert Uytterhoeven <geert@linux-m68k.org>

    commit 9a499db0325b8a8e2368f21fef66705b120f38ba upstream.

    Casting spi_driver pointers to "void *" when calling
    spi_{,un}register_driver() bypasses all type checking.

    Remove the superfluous casts to fix this.

    Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/tty/serial/ifx6x60.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- a/drivers/tty/serial/ifx6x60.c
    +++ b/drivers/tty/serial/ifx6x60.c
    @@ -1381,7 +1381,7 @@ static void __exit ifx_spi_exit(void)
    /* unregister */
    tty_unregister_driver(tty_drv);
    put_tty_driver(tty_drv);
    - spi_unregister_driver((void *)&ifx_spi_driver);
    + spi_unregister_driver(&ifx_spi_driver);
    unregister_reboot_notifier(&ifx_modem_reboot_notifier_block);
    }

    @@ -1420,7 +1420,7 @@ static int __init ifx_spi_init(void)
    goto err_free_tty;
    }

    - result = spi_register_driver((void *)&ifx_spi_driver);
    + result = spi_register_driver(&ifx_spi_driver);
    if (result) {
    pr_err("%s: spi_register_driver failed(%d)",
    DRVNAME, result);
    @@ -1436,7 +1436,7 @@ static int __init ifx_spi_init(void)

    return 0;
    err_unreg_spi:
    - spi_unregister_driver((void *)&ifx_spi_driver);
    + spi_unregister_driver(&ifx_spi_driver);
    err_unreg_tty:
    tty_unregister_driver(tty_drv);
    err_free_tty:
    \
     
     \ /
      Last update: 2017-09-10 01:32    [W:4.067 / U:0.304 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site