lkml.org 
[lkml]   [2017]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 031/233] btrfs: fix incorrect error return ret being passed to mapping_set_error
    3.16.48-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Colin Ian King <colin.king@canonical.com>

    commit bff5baf8aa37a97293725a16c03f49872249c07e upstream.

    The setting of return code ret should be based on the error code
    passed into function end_extent_writepage and not on ret. Thanks
    to Liu Bo for spotting this mistake in the original fix I submitted.

    Detected by CoverityScan, CID#1414312 ("Logically dead code")

    Fixes: 5dca6eea91653e ("Btrfs: mark mapping with error flag to report errors to userspace")
    Signed-off-by: Colin Ian King <colin.king@canonical.com>
    Reviewed-by: Liu Bo <bo.li.liu@oracle.com>
    Signed-off-by: David Sterba <dsterba@suse.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    fs/btrfs/extent_io.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/fs/btrfs/extent_io.c
    +++ b/fs/btrfs/extent_io.c
    @@ -2368,7 +2368,7 @@ int end_extent_writepage(struct page *pa
    if (!uptodate) {
    ClearPageUptodate(page);
    SetPageError(page);
    - ret = ret < 0 ? ret : -EIO;
    + ret = err < 0 ? err : -EIO;
    mapping_set_error(page->mapping, ret);
    }
    return 0;
    \
     
     \ /
      Last update: 2017-09-10 01:27    [W:2.975 / U:0.144 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site