lkml.org 
[lkml]   [2017]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 139/233] USB: quirks: Apply ALWAYS_POLL to all ELAN devices
    3.16.48-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Adrien Vergé <adrienverge@gmail.com>

    commit 33bd2dd03dd0bfa1130d11062a9e5f40d0cf1d3f upstream.

    All ELAN hid devices seem to require the ALWAYS_POLL quirk. Let's use
    this quirk for all devices from this vendor, rather than maintaining a
    list of all its known product IDs.

    Tested-by: Adrien Vergé <adrienverge@gmail.com>
    Signed-off-by: Adrien Vergé <adrienverge@gmail.com>
    Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    Reviewed-by: Jiri Kosina <jkosina@suse.cz>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/hid/hid-ids.h | 5 -----
    drivers/hid/usbhid/hid-quirks.c | 9 +++------
    2 files changed, 3 insertions(+), 11 deletions(-)

    --- a/drivers/hid/hid-ids.h
    +++ b/drivers/hid/hid-ids.h
    @@ -301,11 +301,6 @@
    #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_A001 0xa001

    #define USB_VENDOR_ID_ELAN 0x04f3
    -#define USB_DEVICE_ID_ELAN_TOUCHSCREEN 0x0089
    -#define USB_DEVICE_ID_ELAN_TOUCHSCREEN_009B 0x009b
    -#define USB_DEVICE_ID_ELAN_TOUCHSCREEN_0103 0x0103
    -#define USB_DEVICE_ID_ELAN_TOUCHSCREEN_010c 0x010c
    -#define USB_DEVICE_ID_ELAN_TOUCHSCREEN_016F 0x016f

    #define USB_VENDOR_ID_ELECOM 0x056e
    #define USB_DEVICE_ID_ELECOM_BM084 0x0061
    --- a/drivers/hid/usbhid/hid-quirks.c
    +++ b/drivers/hid/usbhid/hid-quirks.c
    @@ -73,11 +73,7 @@ static const struct hid_blacklist {
    { USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_PIXART_USB_OPTICAL_MOUSE, HID_QUIRK_ALWAYS_POLL },
    { USB_VENDOR_ID_DMI, USB_DEVICE_ID_DMI_ENC, HID_QUIRK_NOGET },
    { USB_VENDOR_ID_DRAGONRISE, USB_DEVICE_ID_DRAGONRISE_WIIU, HID_QUIRK_MULTI_INPUT },
    - { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN, HID_QUIRK_ALWAYS_POLL },
    - { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN_009B, HID_QUIRK_ALWAYS_POLL },
    - { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN_0103, HID_QUIRK_ALWAYS_POLL },
    - { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN_010c, HID_QUIRK_ALWAYS_POLL },
    - { USB_VENDOR_ID_ELAN, USB_DEVICE_ID_ELAN_TOUCHSCREEN_016F, HID_QUIRK_ALWAYS_POLL },
    + { USB_VENDOR_ID_ELAN, HID_ANY_ID, HID_QUIRK_ALWAYS_POLL },
    { USB_VENDOR_ID_ELO, USB_DEVICE_ID_ELO_TS2700, HID_QUIRK_NOGET },
    { USB_VENDOR_ID_FORMOSA, USB_DEVICE_ID_FORMOSA_IR_RECEIVER, HID_QUIRK_NO_INIT_REPORTS },
    { USB_VENDOR_ID_FREESCALE, USB_DEVICE_ID_FREESCALE_MX28, HID_QUIRK_NOGET },
    @@ -341,7 +337,8 @@ static const struct hid_blacklist *usbhi

    for (; hid_blacklist[n].idVendor; n++)
    if (hid_blacklist[n].idVendor == idVendor &&
    - hid_blacklist[n].idProduct == idProduct)
    + (hid_blacklist[n].idProduct == (__u16) HID_ANY_ID ||
    + hid_blacklist[n].idProduct == idProduct))
    bl_entry = &hid_blacklist[n];

    if (bl_entry != NULL)
    \
     
     \ /
      Last update: 2017-09-10 01:13    [W:6.231 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site