lkml.org 
[lkml]   [2017]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 187/233] genirq: Release resources in __setup_irq() error path
    3.16.48-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Heiner Kallweit <hkallweit1@gmail.com>

    commit fa07ab72cbb0d843429e61bf179308aed6cbe0dd upstream.

    In case __irq_set_trigger() fails the resources requested via
    irq_request_resources() are not released.

    Add the missing release call into the error handling path.

    Fixes: c1bacbae8192 ("genirq: Provide irq_request/release_resources chip callbacks")
    Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Link: http://lkml.kernel.org/r/655538f5-cb20-a892-ff15-fbd2dd1fa4ec@gmail.com
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    kernel/irq/manage.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/kernel/irq/manage.c
    +++ b/kernel/irq/manage.c
    @@ -1174,8 +1174,10 @@ __setup_irq(unsigned int irq, struct irq
    ret = __irq_set_trigger(desc, irq,
    new->flags & IRQF_TRIGGER_MASK);

    - if (ret)
    + if (ret) {
    + irq_release_resources(desc);
    goto out_mask;
    + }
    }

    desc->istate &= ~(IRQS_AUTODETECT | IRQS_SPURIOUS_DISABLED | \
    \
     
     \ /
      Last update: 2017-09-10 01:08    [W:5.170 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site