Messages in this thread | | | Subject | Re: [PATCH] ASoC: fsl_ssi: Override bit clock rate based on slot number | From | Arnaud Mouiche <> | Date | Fri, 8 Sep 2017 08:14:32 +0200 |
| |
On 08/09/2017 07:42, Nicolin Chen wrote: > On Thu, Sep 07, 2017 at 10:23:43PM -0700, Nicolin Chen wrote: >> The set_sysclk() now is used to override the output bit clock rate. >> But this is not a common way to implement a set_dai_sysclk(). And >> this creates a problem when a general machine driver (simple-card >> for example) tries to do set_dai_sysclk() by passing an input clock >> rate for the baud clock instead of setting the bit clock rate as >> fsl_ssi driver expected. >> >> So this patch solves this problem by firstly removing set_sysclk() >> since the hw_params() can calculate the bit clock rate. Secondly, >> in order not to break those TDM use cases which previously might >> have been using set_sysclk() to override the bit clock rate, this >> patch changes the driver to override it based on the slot number. >> >> The patch also removes an obsolete comment of the dir parameter. >> >> Signed-off-by: Nicolin Chen <nicoleotsuka@gmail.com> > Forgot to mention, I think that it's better to wait for a couple of > Tested-by from those who use the TDM mode of SSI before applying it. I can check next monday or tuesday. Arnaud > Thanks > Nicolin
| |