lkml.org 
[lkml]   [2017]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] sound: soc: fsl: Do not set DAI sysclk when it is equal to system freq
    From
    Date
    Hi Fabio,

    > On Tue, Sep 5, 2017 at 6:13 PM, Łukasz Majewski <lukma@denx.de> wrote:
    >
    >> &i2c1 {
    >> clock-frequency = <400000>;
    >> pinctrl-names = "default";
    >> pinctrl-0 = <&pinctrl_i2c1>;
    >> status = "okay";
    >>
    >> codec: tfa9879@6C {
    >> #sound-dai-cells = <0>;
    >> compatible = "tfa9879";
    >
    > This codec seems to miss device tree support. Don't you need something
    > like this?
    >
    > --- a/sound/soc/codecs/tfa9879.c
    > +++ b/sound/soc/codecs/tfa9879.c
    > @@ -312,9 +312,15 @@ static const struct i2c_device_id tfa9879_i2c_id[] = {
    > };
    > MODULE_DEVICE_TABLE(i2c, tfa9879_i2c_id);
    >
    > +static const struct of_device_id tfa9879_of_match[] = {
    > + { .compatible = "nxp,tfa9879", },
    > + { }
    > +};
    > +
    > static struct i2c_driver tfa9879_i2c_driver = {
    > .driver = {
    > .name = "tfa9879",
    > + .of_match_table = tfa9879_of_match,
    > },
    > .probe = tfa9879_i2c_probe,
    > .remove = tfa9879_i2c_remove,
    >


    Maybe it should be added, but the driver is probed via I2C "node" in dts.

    I took the codec (tfa9879) driver as-is.


    --
    Best regards,

    Lukasz Majewski

    --

    DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
    HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
    Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de

    \
     
     \ /
      Last update: 2017-09-06 10:45    [W:6.774 / U:0.472 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site