Messages in this thread | | | Date | Wed, 6 Sep 2017 14:01:44 +0200 | From | Rocco Folino <> | Subject | Re: [PATCH] MIPS: ath79: support devicetree selection |
| |
On Wed, Sep 06, 2017 at 01:14:35PM +0200, Ralf Baechle wrote: > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote: > > > Allow to choose devicetrees from Kconfig. > > > > Signed-off-by: Rocco Folino <rocco.folino@gmail.com> > > --- > > arch/mips/ath79/Kconfig | 44 +++++++++++++++++++++++++++++++++++++++++ > > arch/mips/boot/dts/qca/Makefile | 10 +++++----- > > 2 files changed, 49 insertions(+), 5 deletions(-) > > > > diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig > > index dfc60209dc63..b43d116187af 100644 > > --- a/arch/mips/ath79/Kconfig > > +++ b/arch/mips/ath79/Kconfig > > @@ -1,5 +1,49 @@ > > if ATH79 > > > > +menu "Atheros AR71XX/AR724X/AR913X devicetree selection" > > + > > +config DTB_ATH_DPT_MODULE > > + bool "DPTechnics DPT-Module" > > + select SOC_933X > > There is no symbol SOC_933X. Did you mean SOC_AR933X?
Yes, right
> > Anyway, your patch does more than the changelog ("Allow to choose > devicetrees from Kconfig") says, so please either fix the changelog > or split that into multiple patches with proper changelogs.
Ok, I'll fix everything in the v2
thanks for the comments.
Rocco
| |