Messages in this thread | | | Date | Tue, 5 Sep 2017 13:09:17 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCH v8] arm64: allwinner: h5: add NanoPi NEO Plus2 DT support |
| |
Hi Antony,
Almost good, I'm sorry I missed a few things before.
On Mon, Sep 04, 2017 at 04:30:14PM +0200, Antony Antony wrote: > +&mmc1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc1_pins_a>; > + vmmc-supply = <®_vcc3v3>; > + vqmmc-supply = <®_vcc3v3>; > + mmc-pwrseq = <&wifi_pwrseq>; > + bus-width = <4>; > + non-removable; > + status = "okay";
Please add a new line here.
> + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm";
This should be the actual compatible, not just the vendor.
> + }; > +}; > + > +&mmc2 { > + pinctrl-names = "default"; > + pinctrl-0 = <&mmc2_8bit_pins>; > + vmmc-supply = <®_vcc3v3>; > + bus-width = <8>; > + non-removable; > + cap-mmc-hw-reset; > + boot_device = <0>;
that property should still be removed.
> +&r_pio { > + leds_r_npi: led_pins@0 { > + pins = "PL10"; > + function = "gpio_out"; > + }; > + > + vdd_cpux_r_npi: regulator_pins@0 { > + allwinner,pins = "PL6"; > + allwinner,function = "gpio_out"; > + allwinner,drive = <SUN4I_PINCTRL_10_MA>; > + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; > + }; > +};
And these must be left out.
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |