Messages in this thread | | | Date | Tue, 5 Sep 2017 09:28:36 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH] mm, sparse: fix typo in online_mem_sections |
| |
On Tue 05-09-17 12:32:28, Anshuman Khandual wrote: > On 09/04/2017 04:52 PM, Michal Hocko wrote: > > From: Michal Hocko <mhocko@suse.com> > > > > online_mem_sections accidentally marks online only the first section in > > the given range. This is a typo which hasn't been noticed because I > > haven't tested large 2GB blocks previously. All users of > > Section sizes are normally less than 2GB. Could you please elaborate > why this never got noticed before ?
Section size is 128MB which is the default block size as well. So we have one section per block. But if the amount of memory is very large (64GB - see probe_memory_block_size) then we have a 2GB memory blocks so multiple sections per block. -- Michal Hocko SUSE Labs
| |