Messages in this thread | | | Date | Tue, 5 Sep 2017 08:25:53 +0100 | From | Lee Jones <> | Subject | Re: [PATCH v2 1/3] mfd: Add support for Cherry Trail Dollar Cove TI PMIC |
| |
On Mon, 04 Sep 2017, Takashi Iwai wrote:
> On Mon, 04 Sep 2017 15:37:32 +0200, > Lee Jones wrote: > > > > > +static struct mfd_cell dc_ti_dev[] = { > > > + { > > > + .name = "dc_ti_pwrbtn", > > > + .num_resources = ARRAY_SIZE(power_button_resources), > > > + .resources = power_button_resources, > > > + }, > > > + { > > > > Place these on the same line. > > Does this and ... > > > > > + }, > > > + { > > > + .name = "dc_ti_region", > > > + }, > > > > This should be a one line entry: > > > > { .name = "dc_ti_region" }, > > .... this match together? The result would be like: > > static struct mfd_cell dc_ti_dev[] = { > { > .name = "dc_ti_pwrbtn", > .num_resources = ARRAY_SIZE(power_button_resources), > .resources = power_button_resources, > }, { > .name = "chtdc_ti_adc", > .num_resources = ARRAY_SIZE(adc_resources), > ..... > }, { .name = "chtdc_ti_region", }, > }; > > which I find a bit inconsistent.
No, it doesn't.
The single lines need to be on their own.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |