Messages in this thread | | | Date | Mon, 4 Sep 2017 15:23:50 +0300 | From | Yury Norov <> | Subject | Re: [PATCH] Unifying headers for AArch64 and ARM |
| |
Hi Kaushik,
(CC arm and arch maintainers)
On Fri, Sep 01, 2017 at 12:24:08PM +0000, Kaushik Phatak wrote: > Ping for this patch: > https://lkml.org/lkml/2017/8/10/136 > > The patch can be viewed on the mail-archive link below, > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1465874.html > > Please let me know if anyone has any feedback on this. > Thanks. > > Best Regards, > Kaushik M. Phatak > > -----Original Message----- > From: Kaushik Phatak > Sent: Thursday, August 10, 2017 2:12 PM > To: 'linux-kernel@vger.kernel.org' <linux-kernel@vger.kernel.org> > Subject: [PATCH] Unifying headers for AArch64 and ARM > > Hi, > This patch is an attempt to unify the kernel header files for AArch64 and ARM. > We have developed similar patch for glibc, which unifies the headers in sysdeps. > We plan to post that separately to libc-alpha. > > This developed patch is similar to something that X86 does with the macros > (__x86_64__) and (__ILP32__).
scripts/checkpatch.pl reports 30 errors and 24 warnings on your patch. Also, you didn't CC maintainers, so they most probably missed your patch in LKML noise. I CCed some of them here. scripts/get_maintainers.pl should point you to proper persons.
> We have noticed some activity in this area in recent times, Linux patches by Yury Norov: > [07/20] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 > https://patchwork.kernel.org/patch/9599053/
arm64/ilp32 and arm64/lp64 is the single platform, and so lp64 and ilp32 parts share the same installed kernel headers. That's why I had to introduce #ifdef magic here and in other kernel and glibc headers.
Arm32 is different platform, so I don't understand what the benefit in joining headers. Could you explain it in details.
Your patch has 2880 lines. It's quite difficult to read it at once (and I didn't do that). Is it possible split in into the series?
Yury
| |