lkml.org 
[lkml]   [2017]   [Sep]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] Staging: rtl8723bs: Remove unnecessary comments.
From
Date
On Sat, 2017-09-30 at 21:06 +1000, Tobin C. Harding wrote:
> Hi Shreeya,
>
> We don't usually add a period to the subject line for kernel patches.
> (reason: we only have about
> 52 characters for the commit brief description so best not to waste
> any).
>
> On Sat, Sep 30, 2017 at 01:30:34PM +0530, Shreeya Patel wrote:
> >
> > This patch removes unnecessary comments which are there
> > to explain why call to memset is in comments. Both of the
> > comments are not needed as they are not very useful.
> You may like to read Documentation/process/submitting-patches.rst
> (specifically
> section 2) for tips on writing your git log.
>
>         Describe your changes in imperative mood, e.g. "make xyzzy do
> frotz"
>         instead of "[This patch] makes xyzzy do frotz" or "[I]
> changed xyzzy
>         to do frotz", as if you are giving orders to the codebase to
> change
>         its behaviour.
>
> Good luck,
> Tobin.

Hello,

Thanks for correcting me :)
I'll do the necessary changes and will send as v3.


\
 
 \ /
  Last update: 2017-09-30 13:15    [W:0.046 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site