Messages in this thread | | | From | Cong Wang <> | Date | Fri, 29 Sep 2017 10:35:20 -0700 | Subject | Re: [PATCH][net-next] net_sched: remove redundant assignment to ret |
| |
On Fri, Sep 29, 2017 at 7:01 AM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > The assignment of -EINVAL to variable ret is redundant as it > is being overwritten on the following error exit paths or > to the return value from the following call to basic_set_parms. > Fix this up by removing it. Cleans up clang warning message: > > net/sched/cls_basic.c:185:2: warning: Value stored to 'err' is never read > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
Fixes: 1d8134fea2eb ("net_sched: use idr to allocate basic filter handles")
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
| |