lkml.org 
[lkml]   [2017]   [Sep]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH V2 for-next 6/8] RDMA/hns: Add return statement when checking error in hns_roce_v1_mr_free_work_fn
    Date
    After the loop in hns_roce_v1_mr_free_work_fn function, it is possible that
    the local variable named hr_qp is NULL, the operation "hr_qp->qpn" will
    result in the exception. As a result, we add return statement when checking
    error.

    This patch fixes the smatch error as below:
    drivers/infiniband/hw/hns/hns_roce_hw_v1.c:1009 hns_roce_v1_mr_free_work_fn()
    error: we previously assumed 'hr_qp' could be null

    Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
    Signed-off-by: Lijun Ou <oulijun@huawei.com>
    Signed-off-by: Shaobo Xu <xushaobo2@huawei.com>
    ---
    drivers/infiniband/hw/hns/hns_roce_hw_v1.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
    index d82b4de..15e0f2e 100644
    --- a/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
    +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v1.c
    @@ -1004,6 +1004,11 @@ static void hns_roce_v1_mr_free_work_fn(struct work_struct *work)
    }
    }

    + if (!ne) {
    + dev_err(dev, "Reseved loop qp is absent!\n");
    + goto free_work;
    + }
    +
    do {
    ret = hns_roce_v1_poll_cq(&mr_free_cq->ib_cq, ne, wc);
    if (ret < 0) {
    --
    1.9.1
    \
     
     \ /
      Last update: 2017-09-29 16:43    [W:7.229 / U:2.476 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site