Messages in this thread | | | From | Gregory CLEMENT <> | Subject | Re: [PATCH net] net: mvpp2: Fix clock resource by adding an optional bus clock | Date | Thu, 28 Sep 2017 17:52:19 +0200 |
| |
Hi Thomas,
On jeu., sept. 28 2017, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:
>> /* List of pointers to port structures */ >> struct mvpp2_port **port_list; >> @@ -7963,6 +7964,16 @@ static int mvpp2_probe(struct platform_device *pdev) >> err = clk_prepare_enable(priv->mg_clk); >> if (err < 0) >> goto err_gop_clk; >> + >> + priv->axi_clk = devm_clk_get(&pdev->dev, "axi_clk"); >> + if (IS_ERR(priv->axi_clk)) { >> + err = PTR_ERR(priv->axi_clk); >> + priv->axi_clk = NULL; > > You should handle -EPROBE_DEFER here. Indeed, if we have -EPROBE_DEFER, > we shouldn't treat it as "the clock doesn't exist, so let's skip it and > continue", but rather as "the clock exists, but isn't ready to use yet, > let's try later".
You're totally right, I will send a v2 (I will also fix the other issue you spotted).
Thanks,
Gregory
> > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
-- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
| |