Messages in this thread | | | From | Felipe Balbi <> | Subject | Re: [PATCH v2 16/31] usb/phy-isp1301-omap: Remove .data assignment | Date | Thu, 28 Sep 2017 12:36:15 +0300 |
| |
Hi,
Kees Cook <keescook@chromium.org> writes: > The .data assignment appears to be redundant to the WORK_STOP bit for > stopping the timer. Also, it appears this timer is entirely unused > as it is only ever started under #define VERBOSE, which is explicitly > undefined. > > Cc: Felipe Balbi <balbi@kernel.org> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: linux-usb@vger.kernel.org > Cc: linux-omap@vger.kernel.org > Signed-off-by: Kees Cook <keescook@chromium.org>
Are you merging these as part of a larger series altogether, or should I pick the patches that concern me?
If you're taking them all together:
Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
-- balbi [unhandled content-type:application/pgp-signature]
| |