lkml.org 
[lkml]   [2017]   [Sep]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ipmi: pr_err() strings should end with newlines
From
Date
On 09/25/2017 02:49 AM, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.

Thanks, it's queued for the next release.

-corey

> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/char/ipmi/ipmi_dmi.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_dmi.c b/drivers/char/ipmi/ipmi_dmi.c
> index 2a84401..66dafcd 100644
> --- a/drivers/char/ipmi/ipmi_dmi.c
> +++ b/drivers/char/ipmi/ipmi_dmi.c
> @@ -71,13 +71,13 @@ static void __init dmi_add_platform_ipmi(unsigned long base_addr,
> size = 2;
> break;
> default:
> - pr_err("ipmi:dmi: Invalid IPMI type: %d", type);
> + pr_err("ipmi:dmi: Invalid IPMI type: %d\n", type);
> return;
> }
>
> pdev = platform_device_alloc(name, ipmi_dmi_nr);
> if (!pdev) {
> - pr_err("ipmi:dmi: Error allocation IPMI platform device");
> + pr_err("ipmi:dmi: Error allocation IPMI platform device\n");
> return;
> }
> pdev->driver_override = override;
> @@ -239,7 +239,7 @@ static void __init dmi_decode_ipmi(const struct dmi_header *dm)
> offset = 16;
> break;
> default:
> - pr_err("ipmi:dmi: Invalid offset: 0");
> + pr_err("ipmi:dmi: Invalid offset: 0\n");
> return;
> }
> }


\
 
 \ /
  Last update: 2017-09-27 22:35    [W:0.035 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site