Messages in this thread | | | From | Chen-Yu Tsai <> | Date | Mon, 25 Sep 2017 17:19:07 +0800 | Subject | Re: [linux-sunxi] Re: [RFC PATCH 6/7] arm64: allwinner: a64: add power supply nodes in AXP803 DTSI |
| |
On Mon, Sep 25, 2017 at 5:14 PM, Icenowy Zheng <icenowy@aosc.io> wrote: > > > 于 2017年9月25日 GMT+08:00 下午5:11:57, Quentin Schulz <quentin.schulz@free-electrons.com> 写到: >>Hi Icenowy, >> >>On 20/09/2017 17:18, Icenowy Zheng wrote: >>> AXP803 PMIC features AC/USB/Battery power supplies. >>> >>> As we have now the device tree bindings for them, add device tree >>> nodes for them. >>> >>> Signed-off-by: Icenowy Zheng <icenowy@aosc.io> >>> --- >>> arch/arm64/boot/dts/allwinner/axp803.dtsi | 15 +++++++++++++++ >>> 1 file changed, 15 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/allwinner/axp803.dtsi >>b/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> index ff8af52743ff..3a8615231b7c 100644 >>> --- a/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> +++ b/arch/arm64/boot/dts/allwinner/axp803.dtsi >>> @@ -49,6 +49,16 @@ >>> interrupt-controller; >>> #interrupt-cells = <1>; >>> >>> + ac_power_supply: ac-power-supply { >>> + compatible = "x-powers,axp221-ac-power-supply"; >>> + status = "disabled"; >>> + }; >>> + >>> + battery_power_supply: battery-power-supply { >>> + compatible = "x-powers,axp803-battery-power-supply"; >>> + status = "disabled"; >>> + }; >>> + >>> regulators { >>> /* Default work frequency for buck regulators */ >>> x-powers,dcdc-freq = <3000>; >>> @@ -147,4 +157,9 @@ >>> regulator-name = "rtc-ldo"; >>> }; >>> }; >>> + >>> + usb_power_supply: usb_power_supply { >>> + compatible = "x-powers,axp803-usb-power-supply"; >>> + status = "disabled"; >>> + }; >> >>No. You have added support for the AC and battery power supply drivers >>in this patchset, not for USB. > > But I added its device tree binding.
Please do both at the same time. If you only add the binding without the driver, how can you be sure the binding would be a proper fit? Moreover, no one can actually test it.
ChenYu
| |