lkml.org 
[lkml]   [2017]   [Sep]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: ALSA: bebob: Use common error handling code in snd_bebob_stream_start_duplex()
    From
    Date
    > 668     if (!amdtp_stream_wait_callback(&bebob->tx_stream,
    > 669                                     CALLBACK_TIMEOUT)) {
    > 670         amdtp_stream_stop(&bebob->tx_stream);
    > 671         amdtp_stream_stop(&bebob->rx_stream);
    > 672         break_both_connections(bebob);
    > 673         err = -ETIMEDOUT;
    > 674     }
    > 675 }
    >
    > I think it better to apply your solution too in the above to keep code consistency.

    How do you think about to adjust this function implementation after the other two
    update steps from the patch series would be integrated?


    > For the other patches, I can find no merit to apply except for reduction
    > of the number of characters included in the file.

    Would you like to refer to any specific update suggestions for further clarification?

    Regards,
    Markus

    \
     
     \ /
      Last update: 2017-09-24 09:08    [W:4.005 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site