Messages in this thread | | | Date | Thu, 21 Sep 2017 16:05:54 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v2 00/12] x86/crypto: Fix RBP usage in several crypto .S files |
| |
On Mon, Sep 18, 2017 at 02:41:59PM -0500, Josh Poimboeuf wrote: > v2: > - fix performance issues in sha256-avx2-asm.S and sha512-avx2-asm.S > (Eric) > > Many of the x86 crypto functions use RBP as a temporary register. This > breaks frame pointer convention, and breaks stack traces when unwinding > from an interrupt in the crypto code. > > Convert most* of them to leave RBP alone. > > These pass the crypto boot tests for me. Any further testing would be > appreciated! > > [*] There are still a few crypto files left that need fixing, but the > fixes weren't trivial and nobody reported unwinder warnings about > them yet, so I'm skipping them for now. > > Josh Poimboeuf (12):
All applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |